Changeset 93

Timestamp:

11/19/08 13:34:52 (17 years ago)

Author:

yumileroy

Message:

[svn] Fix cloak of shadows. Dispel type should be based on SPELL_DAMAGE_CLASS_MAGIC.
Fix: SPELL_DAMAGE_CLASS_NONE type spells should never miss.

Original author: megamage
Date: 2008-10-21 17:10:05-05:00

Location:

trunk/src/game

Files:

• SpellEffects.cpp (modified) (1 diff)
• Unit.cpp (modified) (1 diff)

trunk/src/game/SpellEffects.cpp

@@ -1774 +1774 @@
                 if( // ignore positive and passive auras
                     !iter->second->IsPositive() && !iter->second->IsPassive()    &&
-                    // ignore physical auras
-                    (GetSpellSchoolMask(iter->second->GetSpellProto()) & SPELL_SCHOOL_MASK_NORMAL)==0 &&
+                    // only affect magic spells
+                    iter->second->GetSpellProto()->DmgClass == SPELL_DAMAGE_CLASS_MAGIC &&
                     // ignore immunity persistent spells
                     !( iter->second->GetSpellProto()->AttributesEx & 0x10000 ) )

trunk/src/game/Unit.cpp

@@ -2906 +2906 @@
             return SPELL_MISS_NONE;
         case SPELL_DAMAGE_CLASS_NONE:
+            return SPELL_MISS_NONE;
         case SPELL_DAMAGE_CLASS_MAGIC:
             return MagicSpellHitResult(pVictim, spell);