Changeset 112 for trunk/src/game/World.cpp

Timestamp:

11/19/08 13:37:14 (17 years ago)

Author:

yumileroy

Message:

[svn] * Merge CLI Commands with regular commands and give them level4 access. sec_console. Source mangos - thanks to ogeraisi for the amalgamated patch.
* Redid/Fixed/Added some lang strings.
* As usual remember this is a trunk rev so stability only guaranteed on northern countries of Mars and western parts of Pluto. No warranties outside the solar system, sorry :( . Check with your local government or dictator on regulations regarding export.

Original author: KingPin?
Date: 2008-10-26 13:32:42-05:00

Files:

• trunk/src/game/World.cpp (modified) (6 diffs)

trunk/src/game/World.cpp

@@ -2265 +2265 @@
 
 /// Ban an account or ban an IP address, duration will be parsed using TimeStringToSecs if it is positive, otherwise permban
-uint8 World::BanAccount(std::string type, std::string nameOrIP, std::string duration, std::string reason, std::string author)
+BanReturn World::BanAccount(BanMode mode, std::string nameOrIP, std::string duration, std::string reason, std::string author)
 {
     loginDatabase.escape_string(nameOrIP);
@@ -2272 +2272 @@
     loginDatabase.escape_string(safe_author);
 
-    if(type != "ip" && !normalizePlayerName(nameOrIP))
-        return BAN_NOTFOUND;                                // Nobody to ban
-
     uint32 duration_secs = TimeStringToSecs(duration);
     QueryResult *resultAccounts = NULL;                     //used for kicking
 
     ///- Update the database with ban information
-
-    if(type=="ip")
-    {
-        //No SQL injection as strings are escaped
-        resultAccounts = loginDatabase.PQuery("SELECT id FROM account WHERE last_ip = '%s'",nameOrIP.c_str());
-        loginDatabase.PExecute("INSERT INTO ip_banned VALUES ('%s',UNIX_TIMESTAMP(),UNIX_TIMESTAMP()+%u,'%s','%s')",nameOrIP.c_str(),duration_secs,safe_author.c_str(),reason.c_str());
-    }
-    else if(type=="account")
-    {
-        //No SQL injection as string is escaped
-        resultAccounts = loginDatabase.PQuery("SELECT id FROM account WHERE username = '%s'",nameOrIP.c_str());
-    }
-    else if(type=="character")
-    {
-        //No SQL injection as string is escaped
-        resultAccounts = CharacterDatabase.PQuery("SELECT account FROM characters WHERE name = '%s'",nameOrIP.c_str());
-    }
-    else
-        return BAN_SYNTAX_ERROR;                            //Syntax problem
-
-    if(!resultAccounts)
-        if(type=="ip")
-            return BAN_SUCCESS;                             // ip correctly banned but nobody affected (yet)
-    else
-        return BAN_NOTFOUND;                                // Nobody to ban
+        switch(mode)
+    {
+        case BAN_IP:
+                        //No SQL injection as strings are escaped
+                        resultAccounts = loginDatabase.PQuery("SELECT id FROM account WHERE last_ip = '%s'",nameOrIP.c_str());
+                        loginDatabase.PExecute("INSERT INTO ip_banned VALUES ('%s',UNIX_TIMESTAMP(),UNIX_TIMESTAMP()+%u,'%s','%s')",nameOrIP.c_str(),duration_secs,safe_author.c_str(),reason.c_str());
+                        break;
+                case BAN_ACCOUNT:
+                        //No SQL injection as string is escaped
+                        resultAccounts = loginDatabase.PQuery("SELECT id FROM account WHERE username = '%s'",nameOrIP.c_str());
+                        break;
+                case BAN_CHARACTER:
+                        //No SQL injection as string is escaped
+                        resultAccounts = CharacterDatabase.PQuery("SELECT account FROM characters WHERE name = '%s'",nameOrIP.c_str());
+                        break;
+                default:
+                        return BAN_SYNTAX_ERROR;
+    }
+    
+        if(!resultAccounts)
+        {
+                if(mode==BAN_IP)
+            return BAN_SUCCESS;
+                else
+                        return BAN_NOTFOUND;                                // Nobody to ban
+        }
 
     ///- Disconnect all affected players (for IP it can be several)
@@ -2311 +2309 @@
         uint32 account = fieldsAccount->GetUInt32();
 
-        if(type != "ip")
+        if(mode!=BAN_IP)
+                {
             //No SQL injection as strings are escaped
             loginDatabase.PExecute("INSERT INTO account_banned VALUES ('%u', UNIX_TIMESTAMP(), UNIX_TIMESTAMP()+%u, '%s', '%s', '1')",
                 account,duration_secs,safe_author.c_str(),reason.c_str());
-
-        WorldSession* sess = FindSession(account);
-        if( sess )
+                }
+
+        if (WorldSession* sess = FindSession(account))
             if(std::string(sess->GetPlayerName()) != author)
                 sess->KickPlayer();
@@ -2328 +2327 @@
 
 /// Remove a ban from an account or IP address
-bool World::RemoveBanAccount(std::string type, std::string nameOrIP)
-{
-    if(type == "ip")
+bool World::RemoveBanAccount(BanMode mode, std::string nameOrIP)
+{
+    if (mode == BAN_IP)
     {
         loginDatabase.escape_string(nameOrIP);
@@ -2338 +2337 @@
     {
         uint32 account=0;
-        if(type == "account")
-        {
-            if (!AccountMgr::normilizeString (nameOrIP))
-                return false;
-            
+        if (mode == BAN_ACCOUNT)
             account = accmgr.GetId (nameOrIP);
-        }
-        else if(type == "character")
-        {
-            if(!normalizePlayerName(nameOrIP))
-                return false;
-
+        else if (mode == BAN_CHARACTER)
             account = objmgr.GetPlayerAccountIdByPlayerName (nameOrIP);
-        }
+
         if(!account)
             return false;
@@ -2504 +2494 @@
 void World::ProcessCliCommands()
 {
-    if (cliCmdQueue.empty()) return;
-
-    CliCommandHolder *command;
-    pPrintf p_zprintf;
+    if (cliCmdQueue.empty())
+                return;
+
+    CliCommandHolder::Print* zprint;
     while (!cliCmdQueue.empty())
     {
         sLog.outDebug("CLI command under processing...");
-        command = cliCmdQueue.next();
-        command->Execute();
-        p_zprintf=command->GetOutputMethod();
+        CliCommandHolder *command = cliCmdQueue.next();
+
+                zprint = command->m_print;
+
+                CliHandler(zprint).ParseCommands(command->m_command);
+
         delete command;
     }
+
     // print the console message here so it looks right
-    p_zprintf("TC> ");
+    zprint("TC> ");
 }