Changeset 69

Timestamp:

11/19/08 13:31:22 (17 years ago)

Author:

yumileroy

Message:

[svn] Add Unit::IsWithinCombatDist? function to check melee range and spell range (now range is related to the attacker's bounding_radius and target's combat_reach, not sure if both should be combat_reach).

Original author: megamage
Date: 2008-10-19 14:42:12-05:00

Location:

trunk/src

Files:

• bindings/scripts/include/sc_creature.cpp (modified) (1 diff)
• game/Player.cpp (modified) (2 diffs)
• game/Spell.cpp (modified) (1 diff)
• game/Unit.cpp (modified) (1 diff)
• game/Unit.h (modified) (1 diff)

trunk/src/bindings/scripts/include/sc_creature.cpp

@@ -134 +134 @@
     {
         //If we are within range melee the target
-        if( m_creature->IsWithinDistInMap(m_creature->getVictim(), ATTACK_DISTANCE))
+        if( m_creature->IsWithinCombatDist(m_creature->getVictim(), ATTACK_DISTANCE))
         {
             m_creature->AttackerStateUpdate(m_creature->getVictim());

trunk/src/game/Player.cpp

@@ -1057 +1057 @@
             if (isAttackReady(BASE_ATTACK))
             {
-                if(!IsWithinDistInMap(pVictim, pldistance))
+                if(!IsWithinCombatDist(pVictim, pldistance))
                 {
                     setAttackTimer(BASE_ATTACK,100);
@@ -1094 +1094 @@
             if ( haveOffhandWeapon() && isAttackReady(OFF_ATTACK))
             {
-                if(!IsWithinDistInMap(pVictim, pldistance))
+                if(!IsWithinCombatDist(pVictim, pldistance))
                 {
                     setAttackTimer(OFF_ATTACK,100);

trunk/src/game/Spell.cpp

@@ -4338 +4338 @@
     {
         // distance from target center in checks
-        float dist = m_caster->GetDistance(target->GetPositionX(),target->GetPositionY(),target->GetPositionZ());
-        if(dist > max_range)
+        if(!m_caster->IsWithinCombatDist(target, max_range))
             return SPELL_FAILED_OUT_OF_RANGE;               //0x5A;
-        if(dist < min_range)
+        if(min_range && m_caster->IsWithinCombatDist(target, min_range)) // skip this check if min_range = 0
             return SPELL_FAILED_TOO_CLOSE;
         if( m_caster->GetTypeId() == TYPEID_PLAYER &&

trunk/src/game/Unit.cpp

@@ -407 +407 @@
         reach = 1.0f;
     return IsWithinDistInMap(pVictim, reach);
+}
+
+bool Unit::IsWithinCombatDist(Unit *obj, float dist2compare) const
+{
+    if (!obj || !IsInMap(obj)) return false;
+
+    float dx = GetPositionX() - obj->GetPositionX();
+    float dy = GetPositionY() - obj->GetPositionY();
+    float dz = GetPositionZ() - obj->GetPositionZ();
+    float distsq = dx*dx + dy*dy + dz*dz;
+    //not sure here, or combatreach + combatreach?
+    float sizefactor = GetObjectSize() + obj->GetFloatValue(UNIT_FIELD_COMBATREACH);
+    float maxdist = dist2compare + sizefactor;
+
+    return distsq < maxdist * maxdist;
 }
 

trunk/src/game/Unit.h

@@ -719 +719 @@
         bool haveOffhandWeapon() const;
         bool canReachWithAttack(Unit *pVictim) const;
+        bool IsWithinCombatDist(Unit *obj, float dist2compare) const;
         uint32 m_extraAttacks;